From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 2 May 2019 22:19:29 +0000 (+1200)
Subject: rpc/dns: leak less on memory failure (CID 1363191)
X-Git-Tag: tdb-1.4.1~141
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5389df9b4df4c7140b8ed712d5b6eba7e899a02f;p=thirdparty%2Fsamba.git

rpc/dns: leak less on memory failure (CID 1363191)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c
index 415a7c57a0f..178ed7c51b1 100644
--- a/source4/rpc_server/dnsserver/dnsdata.c
+++ b/source4/rpc_server/dnsserver/dnsdata.c
@@ -873,6 +873,7 @@ static void _dns_add_name(TALLOC_CTX *mem_ctx, const char *name, char ***add_nam
 
 	ptr[count] = talloc_strdup(mem_ctx, name);
 	if (ptr[count] == NULL) {
+		talloc_free(ptr);
 		return;
 	}