From: Ondřej Surý <ondrej@isc.org>
Date: Wed, 15 Apr 2020 10:27:23 +0000 (+0200)
Subject: Fix invalid cast in win32 stdatomic.h shim
X-Git-Tag: v9.17.2~146^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=54168d55c0a44da65c61b588f40ccbdf79cc914a;p=thirdparty%2Fbind9.git

Fix invalid cast in win32 stdatomic.h shim

The InterlockedOr8() and InterlockedAnd8() first argument was cast
to (atomic_int_fast8_t) instead of (atomic_int_fast8_t *), this was
reported by MSVC as:

  warning C4024: '_InterlockedOr8': different types for formal and actual parameter 1
  warning C4024: '_InterlockedAnd8': different types for formal and actual parameter 1
---

diff --git a/lib/isc/win32/include/isc/stdatomic.h b/lib/isc/win32/include/isc/stdatomic.h
index 8eacb011a94..0fccf4600cc 100644
--- a/lib/isc/win32/include/isc/stdatomic.h
+++ b/lib/isc/win32/include/isc/stdatomic.h
@@ -244,7 +244,7 @@ atomic_add_abort() {
 	atomic_fetch_sub_explicit(obj, arg, memory_order_seq_cst)
 
 #define atomic_fetch_and_explicit8(obj, arg, order) \
-	InterlockedAnd8((atomic_int_fast8_t)obj, arg)
+	InterlockedAnd8((atomic_int_fast8_t *)obj, arg)
 
 #define atomic_fetch_and_explicit32(obj, arg, order)                         \
 	(order == memory_order_relaxed                                       \
@@ -299,7 +299,7 @@ atomic_and_abort() {
 	atomic_fetch_and_explicit(obj, arg, memory_order_seq_cst)
 
 #define atomic_fetch_or_explicit8(obj, arg, order) \
-	InterlockedOr8((atomic_int_fast8_t)obj, arg)
+	InterlockedOr8((atomic_int_fast8_t *)obj, arg)
 
 #define atomic_fetch_or_explicit32(obj, arg, order)                            \
 	(order == memory_order_relaxed                                         \