From: Andrew Bartlett <abartlet@samba.org>
Date: Sat, 10 Jul 2004 03:26:43 +0000 (+0000)
Subject: r1428: Remove *completly bogus* memset.  (No doubt my bug, too...).
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~5976
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=54248a405c9459f93f4200ebb0dc71748ae2fc83;p=thirdparty%2Fsamba.git

r1428: Remove *completly bogus* memset.  (No doubt my bug, too...).

This memset could well have clobbered bits of the stack, because
session_key changed from

char session_key[16];

to

DATA_BLOB session_key

Andrew Bartlett
---

diff --git a/source/libsmb/clikrb5.c b/source/libsmb/clikrb5.c
index b9a3dda4944..5fcde4654ad 100644
--- a/source/libsmb/clikrb5.c
+++ b/source/libsmb/clikrb5.c
@@ -442,8 +442,6 @@ failed:
 	krb5_error_code err;
 	BOOL ret = False;
 
-	memset(session_key, 0, 16);
-
 	if (remote)
 		err = krb5_auth_con_getremotesubkey(context, auth_context, &skey);
 	else