From: Serhiy Storchaka Date: Thu, 25 Apr 2024 05:00:42 +0000 (+0300) Subject: gh-117968: Make the test for closed file more safe in the C API tests (GH-118230) X-Git-Tag: v3.13.0b1~273 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=546cbcfa0eeeb533950bd49e30423f3d3bbd5ebe;p=thirdparty%2FPython%2Fcpython.git gh-117968: Make the test for closed file more safe in the C API tests (GH-118230) The behavior of fileno() after fclose() is undefined, but it is the only practical way to check whether the file was closed. Only test this on the known platforms (Linux, Windows, macOS), where we already tested that it works. --- diff --git a/Modules/_testcapi/run.c b/Modules/_testcapi/run.c index fa3251c4b5b3..4fd98b82d762 100644 --- a/Modules/_testcapi/run.c +++ b/Modules/_testcapi/run.c @@ -74,8 +74,10 @@ run_fileexflags(PyObject *mod, PyObject *pos_args) result = PyRun_FileExFlags(fp, filename, start, globals, locals, closeit, pflags); -#if !defined(__wasi__) - /* The behavior of fileno() after fclose() is undefined. */ +#if defined(__linux__) || defined(MS_WINDOWS) || defined(__APPLE__) + /* The behavior of fileno() after fclose() is undefined, but it is + * the only practical way to check whether the file was closed. + * Only test this on the known platforms. */ if (closeit && result && fileno(fp) >= 0) { PyErr_SetString(PyExc_AssertionError, "File was not closed after excution"); Py_DECREF(result);