From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Fri, 7 Oct 2022 13:52:33 +0000 (+0200)
Subject: analyze: add forgotten return statement
X-Git-Tag: v252-rc2~70^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5475e963c5e6ade35404384ba03caf79cb1bc2e5;p=thirdparty%2Fsystemd.git

analyze: add forgotten return statement

We would fail with an assert in sd_bus_message_enter_container() afterwards.
---

diff --git a/src/analyze/analyze-dot.c b/src/analyze/analyze-dot.c
index 13bea4598fc..bf8aa8148fc 100644
--- a/src/analyze/analyze-dot.c
+++ b/src/analyze/analyze-dot.c
@@ -149,7 +149,7 @@ int verb_dot(int argc, char *argv[], void *userdata) {
 
         r = bus_call_method(bus, bus_systemd_mgr, "ListUnits", &error, &reply, NULL);
         if (r < 0)
-                log_error_errno(r, "Failed to list units: %s", bus_error_message(&error, r));
+                return log_error_errno(r, "Failed to list units: %s", bus_error_message(&error, r));
 
         r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(ssssssouso)");
         if (r < 0)