From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 1 Apr 2008 16:18:38 +0000 (+0200)
Subject: smbd: always close the base_fsp even if the real close returned an error
X-Git-Tag: samba-3.3.0pre1~2937
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=547eacf6058d2bc5b41b266b70f8f4747aca4eae;p=thirdparty%2Fsamba.git

smbd: always close the base_fsp even if the real close returned an error

Otherwise we may end up with share mode entry without an open file.

Volker, Jeremy: please check...

metze
---

diff --git a/source/smbd/close.c b/source/smbd/close.c
index 4bd23a35fc8..b06c0d1e9c9 100644
--- a/source/smbd/close.c
+++ b/source/smbd/close.c
@@ -665,10 +665,6 @@ NTSTATUS close_file(files_struct *fsp, enum file_close_type close_type)
 		status = close_normal_file(fsp, close_type);
 	}
 
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
 	if ((base_fsp != NULL) && (close_type != SHUTDOWN_CLOSE)) {
 
 		/*