From: Francis Dupont <fdupont@isc.org>
Date: Mon, 19 Dec 2016 17:28:49 +0000 (+0100)
Subject: [master] Adding a comment marking readPsid & co issue origin
X-Git-Tag: trac5088_base~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=54a2693ff75f7928dec056c7e30067f2f3128490;p=thirdparty%2Fkea.git

[master] Adding a comment marking readPsid & co issue origin
---

diff --git a/src/lib/dhcp/tests/option_custom_unittest.cc b/src/lib/dhcp/tests/option_custom_unittest.cc
index f897958ff8..c24c6b7795 100644
--- a/src/lib/dhcp/tests/option_custom_unittest.cc
+++ b/src/lib/dhcp/tests/option_custom_unittest.cc
@@ -99,6 +99,7 @@ public:
     /// @tparam integer type.
     template<typename T>
     void writeInt(T value, std::vector<uint8_t>& buf) {
+        // This loop is incorrectly compiled by some old g++?!
         for (int i = 0; i < sizeof(T); ++i) {
             buf.push_back(value >> ((sizeof(T) - i - 1) * 8) & 0xFF);
         }
diff --git a/src/lib/dhcp/tests/option_data_types_unittest.cc b/src/lib/dhcp/tests/option_data_types_unittest.cc
index fae60eb82a..cb914b2447 100644
--- a/src/lib/dhcp/tests/option_data_types_unittest.cc
+++ b/src/lib/dhcp/tests/option_data_types_unittest.cc
@@ -44,6 +44,7 @@ public:
     /// @tparam integer type.
     template<typename T>
     void writeInt(T value, std::vector<uint8_t>& buf) {
+        // This loop is incorrectly compiled by some old g++?!
         for (int i = 0; i < sizeof(T); ++i) {
             buf.push_back(value >> ((sizeof(T) - i - 1) * 8) & 0xFF);
         }