From: Mukund Sivaraman Date: Wed, 8 Jan 2014 04:34:12 +0000 (+0530) Subject: [3263] Update tests that allow adding RdataPtr to an RRset when class or type don... X-Git-Tag: bind10-1.2.0beta1-release~107^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5519de5b8255213341664ff91d1dc0695de32f6d;p=thirdparty%2Fkea.git [3263] Update tests that allow adding RdataPtr to an RRset when class or type don't match --- diff --git a/src/lib/dns/tests/rrset_unittest.cc b/src/lib/dns/tests/rrset_unittest.cc index a605caf62b..76270cd1ab 100644 --- a/src/lib/dns/tests/rrset_unittest.cc +++ b/src/lib/dns/tests/rrset_unittest.cc @@ -162,14 +162,22 @@ TEST_F(RRsetTest, addRdataPtr) { rrset_a_empty.addRdata(createRdata(rrset_a_empty.getType(), rrset_a_empty.getClass(), "192.0.2.2")); - addRdataTestCommon(rrset_a); +} +TEST_F(RRsetTest, addRdataPtrMismatched) { // Pointer version of addRdata() doesn't type check and does allow to //add a different type of Rdata as a result. + + // Type mismatch rrset_a_empty.addRdata(createRdata(RRType::NS(), RRClass::IN(), "ns.example.com.")); - EXPECT_EQ(3, rrset_a_empty.getRdataCount()); + EXPECT_EQ(1, rrset_a_empty.getRdataCount()); + + // Class mismatch + rrset_ch_txt.addRdata(createRdata(RRType::TXT(), RRClass::IN(), + "Test String")); + EXPECT_EQ(1, rrset_ch_txt.getRdataCount()); } TEST_F(RRsetTest, iterator) {