From: Martin Schwenke <martin@meltin.net>
Date: Mon, 24 Jun 2019 06:44:37 +0000 (+1000)
Subject: ctdb-database: Fix signed/unsigned comparison by casting
X-Git-Tag: samba-4.11.0rc1~38
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5527f3922fd680a9bd8330434a0c4221f35e51aa;p=thirdparty%2Fsamba.git

ctdb-database: Fix signed/unsigned comparison by casting

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/database/database_conf.c b/ctdb/database/database_conf.c
index 6bdb372bf03..4c7cb2d9ffe 100644
--- a/ctdb/database/database_conf.c
+++ b/ctdb/database/database_conf.c
@@ -96,7 +96,7 @@ static bool database_conf_validate_lock_debug_script(const char *key,
 		       "%s/%s",
 		       path_etcdir(),
 		       basename(script));
-	if (ret >= sizeof(script_path)) {
+	if (ret < 0 || (size_t)ret >= sizeof(script_path)) {
 		D_ERR("lock debug script path too long\n");
 		return false;
 	}