From: Andreas Schneider Date: Tue, 28 Mar 2023 12:46:14 +0000 (+0200) Subject: s3:waf: Fix One Definition Rule (ODR) violation of libsecrets3 X-Git-Tag: talloc-2.4.1~1264 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=553948ba2896098ce3fe4034d7ea5f30e8a5560e;p=thirdparty%2Fsamba.git s3:waf: Fix One Definition Rule (ODR) violation of libsecrets3 ==7109==ERROR: AddressSanitizer: odr-violation (0x7f7d682b4f00): [1] size=88 'ndr_table_secrets' source3/librpc/gen_ndr/ndr_secrets.c:1002:34 [2] size=88 'ndr_table_secrets' source3/librpc/gen_ndr/ndr_secrets.c:1002:34 These globals were registered at these points: [1]: #0 0x7f7d6843eda8 (/lib64/libasan.so.8+0x3eda8) #1 0x7f7d682970ed in _sub_I_00099_1 (bin/shared/private/libsecrets3-samba4.so+0x1a0ed) #2 0x7f7d68af72fd in call_init /usr/src/debug/glibc-2.37/elf/dl-init.c:70 #3 0x7f7d68af72fd in call_init /usr/src/debug/glibc-2.37/elf/dl-init.c:26 [2]: #0 0x7f7d6843eda8 (/lib64/libasan.so.8+0x3eda8) #1 0x7f7d65d423fb in _sub_I_00099_1 (bin/shared/private/libndr-samba4.so+0x3423fb) #2 0x7f7d68af72fd in call_init /usr/src/debug/glibc-2.37/elf/dl-init.c:70 #3 0x7f7d68af72fd in call_init /usr/src/debug/glibc-2.37/elf/dl-init.c:26 Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- diff --git a/source3/wscript_build b/source3/wscript_build index 4042d8e9c8d..ec63417732c 100644 --- a/source3/wscript_build +++ b/source3/wscript_build @@ -469,7 +469,7 @@ bld.SAMBA3_LIBRARY('secrets3', passdb/secrets_lsa.c ''', deps=''' - NDR_SECRETS + ndr-samba4 smbconf samba3util dbwrap