From: Taehee Yoo <ap420073@gmail.com>
Date: Mon, 23 May 2022 16:17:07 +0000 (+0000)
Subject: amt: fix return value of amt_update_handler()
X-Git-Tag: v5.18.4~258
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5559f47604c69623fae85db994492b65a0ce9bcf;p=thirdparty%2Fkernel%2Fstable.git

amt: fix return value of amt_update_handler()

[ Upstream commit ac1dbf55981b88d64312858ea06e3e63001f085d ]

If a relay receives an update message, it lookup a tunnel.
and if there is no tunnel for that message, it should be treated
as an error, not a success.
But amt_update_handler() returns false, which means success.

Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index de4ea518c793f..d376ed89f836c 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -2423,7 +2423,7 @@ static bool amt_update_handler(struct amt_dev *amt, struct sk_buff *skb)
 		}
 	}
 
-	return false;
+	return true;
 
 report:
 	iph = ip_hdr(skb);