From: Batuhan Taşkaya <batuhanosmantaskaya@gmail.com>
Date: Thu, 16 Apr 2020 17:29:12 +0000 (+0300)
Subject: bpo-39793: use the same domain on make_msgid tests (#18698)
X-Git-Tag: v3.9.0a6~93
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5565c30f0b25996a0e73477fc0e1e1aced52b926;p=thirdparty%2FPython%2Fcpython.git

bpo-39793: use the same domain on make_msgid tests (#18698)

* bpo-39793: use same domain on make_msgid tests

* apply suggestions
---

diff --git a/Lib/test/test_email/test_email.py b/Lib/test/test_email/test_email.py
index 8ec39190ea8d..59eabb009219 100644
--- a/Lib/test/test_email/test_email.py
+++ b/Lib/test/test_email/test_email.py
@@ -11,8 +11,8 @@ import textwrap
 from io import StringIO, BytesIO
 from itertools import chain
 from random import choice
-from socket import getfqdn
 from threading import Thread
+from unittest.mock import patch
 
 import email
 import email.policy
@@ -3342,9 +3342,11 @@ multipart/report
             '.test-idstring@testdomain-string>')
 
     def test_make_msgid_default_domain(self):
-        self.assertTrue(
-            email.utils.make_msgid().endswith(
-                '@' + getfqdn() + '>'))
+        with patch('socket.getfqdn') as mock_getfqdn:
+            mock_getfqdn.return_value = domain = 'pythontest.example.com'
+            self.assertTrue(
+                email.utils.make_msgid().endswith(
+                    '@' + domain + '>'))
 
     def test_Generator_linend(self):
         # Issue 14645.
diff --git a/Misc/NEWS.d/next/Tests/2020-02-29-12-58-17.bpo-39793.Og2SUN.rst b/Misc/NEWS.d/next/Tests/2020-02-29-12-58-17.bpo-39793.Og2SUN.rst
new file mode 100644
index 000000000000..6fa0d15ba2fd
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2020-02-29-12-58-17.bpo-39793.Og2SUN.rst
@@ -0,0 +1 @@
+Use the same domain when testing ``make_msgid``. Patch by Batuhan Taskaya.