From: Volker Lendecke <vl@samba.org>
Date: Tue, 25 Mar 2008 21:21:50 +0000 (+0100)
Subject: Fix a segfault
X-Git-Tag: samba-3.3.0pre1~3121
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=559cd9e5a7fac3ce3769d457132cdcb28569b93d;p=thirdparty%2Fsamba.git

Fix a segfault

When we get a NT_STATUS_WRONG_PASSWORD for example, my_info3 is not initialized
at all. So first check that we have NT_STATUS_IS_OK(status) before we
dereference my_info3.
---

diff --git a/source/winbindd/winbindd_pam.c b/source/winbindd/winbindd_pam.c
index c56eb1b3f89..5712f086038 100644
--- a/source/winbindd/winbindd_pam.c
+++ b/source/winbindd/winbindd_pam.c
@@ -1362,7 +1362,7 @@ NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain,
 	 * caller, we look up the account flags ourselve - gd */
 
 	if ((state->request.flags & WBFLAG_PAM_INFO3_TEXT) && 
-	    (my_info3->base.acct_flags == 0) && NT_STATUS_IS_OK(result)) {
+	    NT_STATUS_IS_OK(result) && (my_info3->base.acct_flags == 0)) {
 
 		struct rpc_pipe_client *samr_pipe;
 		POLICY_HND samr_domain_handle, user_pol;