From: Volker Lendecke Date: Tue, 19 Nov 2019 13:23:52 +0000 (+0100) Subject: smbd: Fix CID 1455912 Logically dead code X-Git-Tag: ldb-2.1.0~676 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=55b0011aaf6b9c46bece711089d89bb1a6317cfa;p=thirdparty%2Fsamba.git smbd: Fix CID 1455912 Logically dead code Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider --- diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c index ad993cc95b0..6a3b1f77688 100644 --- a/source3/smbd/oplock.c +++ b/source3/smbd/oplock.c @@ -1032,7 +1032,7 @@ static void process_oplock_break_message(struct messaging_context *msg_ctx, return; } - if ((break_from == SMB2_LEASE_NONE) && !break_needed) { + if (break_from == SMB2_LEASE_NONE) { struct file_id_buf idbuf; DBG_NOTICE("Already downgraded oplock to none on %s: %s\n", file_id_str_buf(fsp->file_id, &idbuf), @@ -1043,7 +1043,7 @@ static void process_oplock_break_message(struct messaging_context *msg_ctx, DEBUG(10, ("break_from=%u, break_to=%u\n", (unsigned)break_from, (unsigned)break_to)); - if ((break_from == break_to) && !break_needed) { + if (break_from == break_to) { struct file_id_buf idbuf; DBG_NOTICE("Already downgraded oplock to %u on %s: %s\n", (unsigned)break_to,