From: Noel Power Date: Fri, 26 Jul 2019 15:06:54 +0000 (+0000) Subject: s4/libcli/raw: clang: Fix 'Access to field results in a deref of a null ptr X-Git-Tag: talloc-2.3.1~687 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=55c6e4bcc1b084fc391c21b387694a099a015c83;p=thirdparty%2Fsamba.git s4/libcli/raw: clang: Fix 'Access to field results in a deref of a null ptr Fixes: source4/libcli/raw/rawfileinfo.c:301:56: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang] parms->standard.out.create_time = raw_pull_dos_date2(session->transport, ^ source4/libcli/raw/rawfileinfo.c:314:55: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang] parms->ea_size.out.create_time = raw_pull_dos_date2(session->transport, Signed-off-by: Noel Power Reviewed-by: Andreas Schneider --- diff --git a/source4/libcli/raw/rawfileinfo.c b/source4/libcli/raw/rawfileinfo.c index a2599085ab7..cbc4fbd4e8b 100644 --- a/source4/libcli/raw/rawfileinfo.c +++ b/source4/libcli/raw/rawfileinfo.c @@ -297,6 +297,10 @@ static NTSTATUS smb_raw_info_backend(struct smbcli_session *session, return NT_STATUS_INVALID_LEVEL; case RAW_FILEINFO_STANDARD: + if (session == NULL) { + return NT_STATUS_INVALID_PARAMETER; + } + FINFO_CHECK_SIZE(22); parms->standard.out.create_time = raw_pull_dos_date2(session->transport, blob->data + 0); @@ -310,6 +314,10 @@ static NTSTATUS smb_raw_info_backend(struct smbcli_session *session, return NT_STATUS_OK; case RAW_FILEINFO_EA_SIZE: + if (session == NULL) { + return NT_STATUS_INVALID_PARAMETER; + } + FINFO_CHECK_SIZE(26); parms->ea_size.out.create_time = raw_pull_dos_date2(session->transport, blob->data + 0);