From: Gao Feng <gfree.wind@vip.163.com>
Date: Tue, 31 Oct 2017 10:25:37 +0000 (+0800)
Subject: ppp: Destroy the mutex when cleanup
X-Git-Tag: v4.4.107~26
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=561b9d998e654801d439529adb7aa09e3a0d33d4;p=thirdparty%2Fkernel%2Fstable.git

ppp: Destroy the mutex when cleanup


[ Upstream commit f02b2320b27c16b644691267ee3b5c110846f49e ]

The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the
good readbility, it's better to invoke it in exit func when the init
func invokes mutex_init.

Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Acked-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index dc454138d600b..e2decf71c6d1f 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -942,6 +942,7 @@ static __net_exit void ppp_exit_net(struct net *net)
 	unregister_netdevice_many(&list);
 	rtnl_unlock();
 
+	mutex_destroy(&pn->all_ppp_mutex);
 	idr_destroy(&pn->units_idr);
 }