From: Gary Lockyer <gary@catalyst.net.nz>
Date: Fri, 7 Jun 2019 03:19:25 +0000 (+1200)
Subject: lib ldb ldb_key_value: csbuild fix signed unsigned compare
X-Git-Tag: ldb-2.0.5~382
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=566ca19482afc3c18fc157be49431b1901e11397;p=thirdparty%2Fsamba.git

lib ldb ldb_key_value: csbuild fix signed unsigned compare

Fixes csbuild error.

Error: COMPILER_WARNING:
lib/ldb/ldb_key_value/ldb_kv_index.c: scope_hint: In function
‘ldb_kv_index_add1’
lib/ldb/ldb_key_value/ldb_kv_index.c:2601:15: warning: comparison of
integer expressions of different signedness: ‘int’ and ‘unsigned int’
[-Wsign-compare]

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/lib/ldb/ldb_key_value/ldb_kv_index.c b/lib/ldb/ldb_key_value/ldb_kv_index.c
index 5299a073e29..3a96e5ad8b3 100644
--- a/lib/ldb/ldb_key_value/ldb_kv_index.c
+++ b/lib/ldb/ldb_key_value/ldb_kv_index.c
@@ -2596,7 +2596,7 @@ static int ldb_kv_index_add1(struct ldb_module *module,
 		 *
 		 * So need to pull the DN's to check if it's really a duplicate
 		 */
-		int i;
+		unsigned int i;
 		for (i=0; i < list->count; i++) {
 			uint8_t guid_key[LDB_KV_GUID_KEY_SIZE];
 			struct ldb_val key = {