From: Nick Mathewson <nickm@torproject.org>
Date: Sat, 19 Apr 2014 16:47:58 +0000 (-0400)
Subject: scan-build: close stdio FILEs on error in tor-gencert
X-Git-Tag: tor-0.2.5.4-alpha~14^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5670e38efb8529d3439b8a160e9f19c4147e01ad;p=thirdparty%2Ftor.git

scan-build: close stdio FILEs on error in tor-gencert

This is harmless, since tor-gencert exits right afterwards, but it's
best to clean up after ourselves.
---

diff --git a/src/tools/tor-gencert.c b/src/tools/tor-gencert.c
index d0c30b8b02..e799df5cad 100644
--- a/src/tools/tor-gencert.c
+++ b/src/tools/tor-gencert.c
@@ -302,6 +302,7 @@ load_identity_key(void)
     if (!identity_key) {
       log_err(LD_GENERAL, "Couldn't read identity key from %s",
               identity_key_file);
+      fclose(f);
       return 1;
     }
     fclose(f);
@@ -322,6 +323,7 @@ load_signing_key(void)
   }
   if (!(signing_key = PEM_read_PrivateKey(f, NULL, NULL, NULL))) {
     log_err(LD_GENERAL, "Couldn't read siging key from %s", signing_key_file);
+    fclose(f);
     return 1;
   }
   fclose(f);