From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 6 Feb 2020 00:18:32 +0000 (-0500)
Subject: Fix a memory leak in handling GETINFO.
X-Git-Tag: tor-0.4.3.2-alpha~9^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=56c54a66bdc01a9e8b857f22650ca88d8eff5466;p=thirdparty%2Ftor.git

Fix a memory leak in handling GETINFO.

Fixes bug 33103; bugfix on 0.4.3.1-alpha.
---

diff --git a/changes/ticket33103 b/changes/ticket33103
new file mode 100644
index 0000000000..889805f103
--- /dev/null
+++ b/changes/ticket33103
@@ -0,0 +1,3 @@
+  o Minor bugfixes (controller):
+    - Fix a memory leak in GETINFO responses. Fixes bug 33103;
+      bugfix on 0.4.3.1-alpha.
diff --git a/src/feature/control/control_getinfo.c b/src/feature/control/control_getinfo.c
index 6f30878d23..5dcc4b170d 100644
--- a/src/feature/control/control_getinfo.c
+++ b/src/feature/control/control_getinfo.c
@@ -1735,6 +1735,7 @@ handle_control_getinfo(control_connection_t *conn,
       }
     } else {
       control_reply_add_one_kv(answers, 250, KV_RAW, q, ans);
+      tor_free(ans);
     }
   } SMARTLIST_FOREACH_END(q);