From: Jason Kirtland Date: Sun, 19 Aug 2007 14:48:04 +0000 (+0000) Subject: pyflakes mop-up X-Git-Tag: rel_0_4beta4~39 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=56fdb8b29610b02d8eaec47663ad0da362ca70cf;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git pyflakes mop-up --- diff --git a/lib/sqlalchemy/databases/access.py b/lib/sqlalchemy/databases/access.py index 4aa773239d..f901ebf535 100644 --- a/lib/sqlalchemy/databases/access.py +++ b/lib/sqlalchemy/databases/access.py @@ -7,6 +7,7 @@ import random from sqlalchemy import sql, schema, ansisql, types, exceptions, pool +from sqlalchemy.sql import compiler import sqlalchemy.engine.default as default diff --git a/lib/sqlalchemy/databases/informix.py b/lib/sqlalchemy/databases/informix.py index ceb56903a6..45dfb0370e 100644 --- a/lib/sqlalchemy/databases/informix.py +++ b/lib/sqlalchemy/databases/informix.py @@ -506,10 +506,10 @@ class InfoIdentifierPreparer(compiler.IdentifierPreparer): def _requires_quotes(self, value): return False -class InfoSchemaDroper(compiler.SchemaDropper): +class InfoSchemaDropper(compiler.SchemaDropper): def drop_foreignkey(self, constraint): if constraint.name is not None: - super( InfoSchemaDroper , self ).drop_foreignkey( constraint ) + super( InfoSchemaDropper , self ).drop_foreignkey( constraint ) dialect = InfoDialect poolclass = pool.SingletonThreadPool diff --git a/lib/sqlalchemy/engine/__init__.py b/lib/sqlalchemy/engine/__init__.py index acac8180ce..070ff3c3e5 100644 --- a/lib/sqlalchemy/engine/__init__.py +++ b/lib/sqlalchemy/engine/__init__.py @@ -164,7 +164,7 @@ def engine_from_config(configuration, prefix='sqlalchemy.', **kwargs): string values. in a future release, this functionality will be expanded to include dialect-specific arguments. """ - + opts = dict([(key[len(prefix):], configuration[key]) for key in configuration if key.startswith(prefix)]) for opt, type_ in ( ('convert_unicode', bool), @@ -177,5 +177,3 @@ def engine_from_config(configuration, prefix='sqlalchemy.', **kwargs): opts.update(kwargs) url = opts.pop('url') return create_engine(url, **opts) - - \ No newline at end of file diff --git a/lib/sqlalchemy/engine/default.py b/lib/sqlalchemy/engine/default.py index 059395921f..17986286d0 100644 --- a/lib/sqlalchemy/engine/default.py +++ b/lib/sqlalchemy/engine/default.py @@ -6,7 +6,7 @@ """Provide default implementations of per-dialect sqlalchemy.engine classes""" -from sqlalchemy import schema, exceptions, sql, util +from sqlalchemy import schema, exceptions, util import re, random from sqlalchemy.engine import base from sqlalchemy.sql import compiler, expression diff --git a/lib/sqlalchemy/orm/interfaces.py b/lib/sqlalchemy/orm/interfaces.py index 9000a8df58..ec180d74a8 100644 --- a/lib/sqlalchemy/orm/interfaces.py +++ b/lib/sqlalchemy/orm/interfaces.py @@ -5,7 +5,7 @@ # the MIT License: http://www.opensource.org/licenses/mit-license.php -from sqlalchemy import util, logging, sql +from sqlalchemy import util, logging from sqlalchemy.sql import expression __all__ = ['EXT_CONTINUE', 'EXT_STOP', 'EXT_PASS', 'MapperExtension', diff --git a/lib/sqlalchemy/orm/mapper.py b/lib/sqlalchemy/orm/mapper.py index 60d4526ec3..51853ddcab 100644 --- a/lib/sqlalchemy/orm/mapper.py +++ b/lib/sqlalchemy/orm/mapper.py @@ -11,7 +11,7 @@ from sqlalchemy.sql import util as sqlutil from sqlalchemy.orm import util as mapperutil from sqlalchemy.orm.util import ExtensionCarrier from sqlalchemy.orm import sync -from sqlalchemy.orm.interfaces import MapperProperty, EXT_CONTINUE, MapperExtension, SynonymProperty +from sqlalchemy.orm.interfaces import MapperProperty, EXT_CONTINUE, SynonymProperty deferred_load = None __all__ = ['Mapper', 'class_mapper', 'object_mapper', 'mapper_registry'] @@ -280,7 +280,7 @@ class Mapper(object): extlist.add(ext_obj) for ext in global_extensions: - if isinstance(ext_class, type): + if isinstance(ext, type): ext = ext() extlist.add(ext) ext.instrument_class(self, self.class_) diff --git a/lib/sqlalchemy/orm/sync.py b/lib/sqlalchemy/orm/sync.py index 49661a95ef..795d76b1af 100644 --- a/lib/sqlalchemy/orm/sync.py +++ b/lib/sqlalchemy/orm/sync.py @@ -9,7 +9,7 @@ attributes between two objects in a manner corresponding to a SQL clause that compares column values. """ -from sqlalchemy import sql, schema, exceptions +from sqlalchemy import schema, exceptions from sqlalchemy.sql import visitors, operators from sqlalchemy import logging from sqlalchemy.orm import util as mapperutil