From: Andrew Tridgell <tridge@samba.org>
Date: Wed, 6 Aug 2008 04:02:45 +0000 (+1000)
Subject: fixed a fd leak when trying to regain contact to a domain controller
X-Git-Tag: samba-3.3.0pre1~273
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=57187cafbcc053e75bb54750494df9feabe3a738;p=thirdparty%2Fsamba.git

fixed a fd leak when trying to regain contact to a domain controller
in winbind

When a w2k3 DC is rebooted the 139/445 ports come up before the
udp/389 cldap port. During this brief period, winbind manages to
connect to 139/445 but not to udp 389. It then enters a tight loop
where it leaks one fd each time. In a couple of seconds it runs out of
file descriptors, and leaves winbind crippled after the DC does
finally come up
---

diff --git a/source/winbindd/winbindd_cm.c b/source/winbindd/winbindd_cm.c
index b3f89506914..47df4e40589 100644
--- a/source/winbindd/winbindd_cm.c
+++ b/source/winbindd/winbindd_cm.c
@@ -1320,6 +1320,7 @@ static bool find_new_dc(TALLOC_CTX *mem_ctx,
 	TALLOC_FREE(addrs);
 	num_addrs = 0;
 
+	close(*fd);
 	*fd = -1;
 
 	goto again;