From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 9 Sep 2019 17:18:09 +0000 (-0700)
Subject: bpo-38070: visit_decref() calls _PyObject_IsFreed() (GH-15782)
X-Git-Tag: v3.8.0rc1~249
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5731172bb1e958b1d80b18eaf88d3f2f93cfccdd;p=thirdparty%2FPython%2Fcpython.git

bpo-38070: visit_decref() calls _PyObject_IsFreed() (GH-15782)


In debug mode, visit_decref() now calls _PyObject_IsFreed() to ensure
that the object is not freed. If it's freed, the program fails with
an assertion error and Python dumps informations about the freed
object.
(cherry picked from commit d91d4de31745fc1ed4c7e6c208917827c9c472b6)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
---

diff --git a/Modules/gcmodule.c b/Modules/gcmodule.c
index 2741edc0a021..b2ee56623cd4 100644
--- a/Modules/gcmodule.c
+++ b/Modules/gcmodule.c
@@ -376,6 +376,8 @@ static int
 visit_decref(PyObject *op, void *data)
 {
     assert(op != NULL);
+    _PyObject_ASSERT(op, !_PyObject_IsFreed(op));
+
     if (PyObject_IS_GC(op)) {
         PyGC_Head *gc = AS_GC(op);
         /* We're only interested in gc_refs for objects in the