From: Xichao Zhao <zhao.xichao@vivo.com>
Date: Mon, 25 Aug 2025 07:36:09 +0000 (+0800)
Subject: exec: Fix incorrect type for ret
X-Git-Tag: v5.4.301~53
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=577b13e5b25f32cc2497ad409b18f8241ac90b89;p=thirdparty%2Fkernel%2Fstable.git

exec: Fix incorrect type for ret

[ Upstream commit 5e088248375d171b80c643051e77ade6b97bc386 ]

In the setup_arg_pages(), ret is declared as an unsigned long.
The ret might take a negative value. Therefore, its type should
be changed to int.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20250825073609.219855-1-zhao.xichao@vivo.com
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/fs/exec.c b/fs/exec.c
index 5dffc67745c8..5aa0d9ec7f21 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -701,7 +701,7 @@ int setup_arg_pages(struct linux_binprm *bprm,
 		    unsigned long stack_top,
 		    int executable_stack)
 {
-	unsigned long ret;
+	int ret;
 	unsigned long stack_shift;
 	struct mm_struct *mm = current->mm;
 	struct vm_area_struct *vma = bprm->vma;