From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 24 May 2013 17:36:15 +0000 (-0400)
Subject: Fix a logic error in 4282 fixes
X-Git-Tag: tor-0.2.5.1-alpha~177^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=57e4324c425e6c9acd58c2270a183ee4d9b1e4aa;p=thirdparty%2Ftor.git

Fix a logic error in 4282 fixes

check_or_create_data_subdir has succeeded when it returns 0, not
when it returns negative.
---

diff --git a/src/or/geoip.c b/src/or/geoip.c
index 73ad211881..1c307dcc57 100644
--- a/src/or/geoip.c
+++ b/src/or/geoip.c
@@ -1146,7 +1146,7 @@ geoip_dirreq_stats_write(time_t now)
   str = geoip_format_dirreq_stats(now);
 
   /* Write dirreq-stats string to disk. */
-  if (check_or_create_data_subdir("stats") < 0) {
+  if (!check_or_create_data_subdir("stats")) {
     write_to_data_subdir("stats", "dirreq-stats", str, "dirreq statistics");
     /* Reset measurement interval start. */
     geoip_reset_dirreq_stats(now);