From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Tue, 17 May 2022 22:45:56 +0000 (-0700) Subject: gh-89898: Fix test_threading.test_args_argument() (GH-92885) X-Git-Tag: v3.11.0b2~81 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=58088a544c825ecc14733699c4cf32377049434e;p=thirdparty%2FPython%2Fcpython.git gh-89898: Fix test_threading.test_args_argument() (GH-92885) Join the thread to not leak threads running in the background to the next test. Fix the following warning on the "AMD64 FreeBSD Shared 3.11" buildbot: test_args_argument (test.test_threading.ThreadTests.test_args_argument) ... Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2) Warning -- Dangling thread: <_MainThread(MainThread, started 35026161664)> Warning -- Dangling thread: ), started 35314998016)> ok (cherry picked from commit 970efae274538f9910e8f9b31bc890f1b7666b0f) Co-authored-by: Victor Stinner --- diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index f7dea136a87c..9c6561c099f5 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -149,6 +149,7 @@ class ThreadTests(BaseTestCase): with self.subTest(target=target, args=args): t = threading.Thread(target=target, args=args) t.start() + t.join() @cpython_only def test_disallow_instantiation(self):