From: Andrew Bartlett <abartlet@samba.org>
Date: Thu, 3 Jan 2013 10:31:22 +0000 (+1100)
Subject: dsdb-acl: give error string if we can not obtain the schema
X-Git-Tag: ldb-1.1.15~179
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5812eb3c1deac51891f01338b4771b1e397dc24d;p=thirdparty%2Fsamba.git

dsdb-acl: give error string if we can not obtain the schema

Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source4/dsdb/samdb/ldb_modules/acl.c b/source4/dsdb/samdb/ldb_modules/acl.c
index 9bf261225ec..2de16b7e98a 100644
--- a/source4/dsdb/samdb/ldb_modules/acl.c
+++ b/source4/dsdb/samdb/ldb_modules/acl.c
@@ -1021,8 +1021,9 @@ static int acl_modify(struct ldb_module *module, struct ldb_request *req)
 
 	schema = dsdb_get_schema(ldb, tmp_ctx);
 	if (!schema) {
-		ret = LDB_ERR_OPERATIONS_ERROR;
-		goto fail;
+		talloc_free(tmp_ctx);
+		return ldb_error(ldb, LDB_ERR_OPERATIONS_ERROR,
+				 "acl_modify: Error obtaining schema.");
 	}
 
 	ret = dsdb_get_sd_from_ldb_message(ldb, tmp_ctx, acl_res->msgs[0], &sd);