From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 24 Jun 2016 13:59:42 +0000 (+0200)
Subject: machined: don't bother explicitly closing the errno pipe
X-Git-Tag: v231~95^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5816a84352e19492df61036d26eff0eb00f2d8c0;p=thirdparty%2Fsystemd.git

machined: don't bother explicitly closing the errno pipe

There's no point in explicitly closing the errno pipe, if we exit right after
anyway. It doesn't hurt doing this either, but let's do this the same way for
all cases where we use the "Operation" object right now, and in all other cases
we do not close the pipe explicitly, hence don't do so here either.
---

diff --git a/src/machine/machine-dbus.c b/src/machine/machine-dbus.c
index de5d98f23ef..f50f363ba30 100644
--- a/src/machine/machine-dbus.c
+++ b/src/machine/machine-dbus.c
@@ -1200,8 +1200,6 @@ int bus_machine_method_copy(sd_bus_message *message, void *userdata, sd_bus_erro
 
         child_fail:
                 (void) write(errno_pipe_fd[1], &r, sizeof(r));
-                errno_pipe_fd[1] = safe_close(errno_pipe_fd[1]);
-
                 _exit(EXIT_FAILURE);
         }