From: Sebastian Hahn Date: Tue, 27 Mar 2012 12:04:15 +0000 (+0200) Subject: Provide large enough buffer in test_util_sscanf() X-Git-Tag: tor-0.2.3.14-alpha~46 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=582f747049ae9595380fe06df8e6b26c735b50c1;p=thirdparty%2Ftor.git Provide large enough buffer in test_util_sscanf() This was causing crashes during unit test runs, as stack smashing protections got triggered. Issue spotted by weasel --- diff --git a/changes/bug5449 b/changes/bug5449 new file mode 100644 index 0000000000..48babb34f8 --- /dev/null +++ b/changes/bug5449 @@ -0,0 +1,6 @@ + o Minor bugfixes: + - In the testsuite, provide a large enough buffer in the tor_sscanf + unit test. We'd otherwise overrun that buffer and crash during the + unit tests. Fixes bug 5449; bugfix on 0.2.3.12-alpha. Thanks weasel + for spotting the bug. + diff --git a/src/test/test_util.c b/src/test/test_util.c index 0187187c0a..9da4cb7994 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -1376,7 +1376,7 @@ static void test_util_sscanf(void) { unsigned u1, u2, u3; - char s1[10], s2[10], s3[10], ch; + char s1[20], s2[10], s3[10], ch; int r; /* Simple tests (malformed patterns, literal matching, ...) */