From: Mark Andrews <marka@isc.org>
Date: Mon, 17 Jun 2024 01:36:41 +0000 (+1000)
Subject: resolver system test didn't record all failures
X-Git-Tag: alessio/regression/026024a6ae~16^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5843b29f472cff3dad8bbc2b381a1f0d917fe862;p=thirdparty%2Fbind9.git

resolver system test didn't record all failures
---

diff --git a/bin/tests/system/resolver/tests.sh b/bin/tests/system/resolver/tests.sh
index fff57498c7b..a728806fb3f 100755
--- a/bin/tests/system/resolver/tests.sh
+++ b/bin/tests/system/resolver/tests.sh
@@ -840,6 +840,7 @@ grep "ANSWER: [12]," dig.out.2.${n} >/dev/null || ret=1
 lines=$(awk '$1 == "mixedttl.tld." && $2 > 30 { print }' dig.out.2.${n} | wc -l)
 test ${lines:-1} -ne 0 && ret=1
 if [ $ret != 0 ]; then echo_i "failed"; fi
+status=$((status + ret))
 
 n=$((n + 1))
 echo_i "check resolver behavior when FORMERR for EDNS options happens (${n})"
@@ -851,6 +852,7 @@ dig_with_opts +tcp @10.53.0.5 options-formerr A >dig.out.${n} || ret=1
 grep "status: NOERROR" dig.out.${n} >/dev/null || ret=1
 nextpart ns5/named.run | grep "$msg" >/dev/null || ret=1
 if [ $ret != 0 ]; then echo_i "failed"; fi
+status=$((status + ret))
 
 n=$((n + 1))
 echo_i "GL#4612 regression test: DS query against broken NODATA responses (${n})"
@@ -859,7 +861,6 @@ ret=0
 dig_with_opts @10.53.0.7 a.a.gl6412 DS >dig.out.${n} || ret=1
 grep "status: SERVFAIL" dig.out.${n} >/dev/null || ret=1
 if [ $ret != 0 ]; then echo_i "failed"; fi
-
 status=$((status + ret))
 
 echo_i "exit status: $status"