From: Ville Syrjälä Date: Mon, 20 Oct 2025 18:50:25 +0000 (+0300) Subject: drm/i915/vrr: Avoid redundant TRANS_PUSH write in intel_vrr_enable() X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=587db4b31094972ad40a429cd8994c8bdcf443b8;p=thirdparty%2Fkernel%2Flinux.git drm/i915/vrr: Avoid redundant TRANS_PUSH write in intel_vrr_enable() We keep TRANS_PUSH_EN always set for always_use_vrr_tg() platfforms, so there is no need to write it again in intel_vrr_enable(). Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20251020185038.4272-10-ville.syrjala@linux.intel.com Reviewed-by: Ankit Nautiyal --- diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c index b2f139addc8ba..6e8f8e673312c 100644 --- a/drivers/gpu/drm/i915/display/intel_vrr.c +++ b/drivers/gpu/drm/i915/display/intel_vrr.c @@ -709,12 +709,12 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state) intel_vrr_set_vrr_timings(crtc_state); - intel_de_write(display, TRANS_PUSH(display, cpu_transcoder), - TRANS_PUSH_EN); - if (!intel_vrr_always_use_vrr_tg(display)) { intel_vrr_set_db_point_and_transmission_line(crtc_state); + intel_de_write(display, TRANS_PUSH(display, cpu_transcoder), + TRANS_PUSH_EN); + if (crtc_state->cmrr.enable) { intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), VRR_CTL_VRR_ENABLE | VRR_CTL_CMRR_ENABLE |