From: Taylor Blau Date: Tue, 24 May 2022 18:54:27 +0000 (-0400) Subject: builtin/pack-objects.c: avoid redundant NULL check X-Git-Tag: v2.37.0-rc0~34^2~2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=58a6abb7bae98357677657825631de6652256be9;p=thirdparty%2Fgit.git builtin/pack-objects.c: avoid redundant NULL check Before calling `for_each_object_in_pack()`, the caller `read_packs_list_from_stdin()` loops through each of the `include_packs` and checks that its `->util` pointer (which is used to store the `struct packed_git *` itself) is non-NULL. This check is redundant, because `read_packs_list_from_stdin()` already checks that the included packs are non-NULL earlier on in the same function (and it does not add any new entries in between). Remove this check, since it is not doing anything in the meantime. Co-authored-by: Victoria Dye Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano --- diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index ba2006f221..f5b098a2d4 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -3361,8 +3361,6 @@ static void read_packs_list_from_stdin(void) for_each_string_list_item(item, &include_packs) { struct packed_git *p = item->util; - if (!p) - die(_("could not find pack '%s'"), item->string); for_each_object_in_pack(p, add_object_entry_from_pack, &revs,