From: Bob Halley <halley@dnspython.org>
Date: Thu, 1 Aug 2024 12:24:07 +0000 (-0700)
Subject: ignore some uninteresting coverage gaps
X-Git-Tag: v2.7.0rc1~27
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=58fdc785b8d9a4c10d603f860e255a482d1623a2;p=thirdparty%2Fdnspython.git

ignore some uninteresting coverage gaps
---

diff --git a/dns/resolver.py b/dns/resolver.py
index df19f194..9dd78192 100644
--- a/dns/resolver.py
+++ b/dns/resolver.py
@@ -45,7 +45,7 @@ import dns.rdtypes.svcbbase
 import dns.reversename
 import dns.tsig
 
-if sys.platform == "win32":
+if sys.platform == "win32":  #  pragma: no cover
     import dns.win32util
 
 
@@ -96,7 +96,7 @@ class NXDOMAIN(dns.exception.DNSException):
                 cname = response.canonical_name()
                 if cname != qname:
                     return cname
-            except Exception:
+            except Exception:  # pragma: no cover
                 # We can just eat this exception as it means there was
                 # something wrong with the response.
                 pass
@@ -334,7 +334,7 @@ class HostAnswers(Answers):
             answers[dns.rdatatype.A] = v4
         return answers
 
-    # Returns pairs of (address, family) from this result, potentiallys
+    # Returns pairs of (address, family) from this result, potentially
     # filtering by address family.
     def addresses_and_families(
         self, family: int = socket.AF_UNSPEC
@@ -347,7 +347,7 @@ class HostAnswers(Answers):
             answer = self.get(dns.rdatatype.AAAA)
         elif family == socket.AF_INET:
             answer = self.get(dns.rdatatype.A)
-        else:
+        else:  # pragma: no cover
             raise NotImplementedError(f"unknown address family {family}")
         if answer:
             for rdata in answer:
@@ -938,7 +938,7 @@ class BaseResolver:
 
         self.reset()
         if configure:
-            if sys.platform == "win32":
+            if sys.platform == "win32":  # pragma: no cover
                 self.read_registry()
             elif filename:
                 self.read_resolv_conf(filename)
@@ -947,7 +947,7 @@ class BaseResolver:
         """Reset all resolver configuration to the defaults."""
 
         self.domain = dns.name.Name(dns.name.from_text(socket.gethostname())[1:])
-        if len(self.domain) == 0:
+        if len(self.domain) == 0:  # pragma: no cover
             self.domain = dns.name.root
         self._nameservers = []
         self.nameserver_ports = {}
@@ -1040,7 +1040,7 @@ class BaseResolver:
         # setter logic, with additonal checking and enrichment.
         self.nameservers = nameservers
 
-    def read_registry(self) -> None:
+    def read_registry(self) -> None:  # pragma: no cover
         """Extract resolver configuration from the Windows registry."""
         try:
             info = dns.win32util.get_dns_info()  # type: ignore
@@ -1429,7 +1429,7 @@ class Resolver(BaseResolver):
         elif family == socket.AF_INET6:
             v6 = self.resolve(name, dns.rdatatype.AAAA, **modified_kwargs)
             return HostAnswers.make(v6=v6)
-        elif family != socket.AF_UNSPEC:
+        elif family != socket.AF_UNSPEC:  # pragma: no cover
             raise NotImplementedError(f"unknown address family {family}")
 
         raise_on_no_answer = modified_kwargs.pop("raise_on_no_answer", True)
@@ -1513,7 +1513,7 @@ class Resolver(BaseResolver):
             nameservers = dns._ddr._get_nameservers_sync(answer, timeout)
             if len(nameservers) > 0:
                 self.nameservers = nameservers
-        except Exception:
+        except Exception:  # pragma: no cover
             pass
 
 
@@ -1638,7 +1638,7 @@ def canonical_name(name: Union[dns.name.Name, str]) -> dns.name.Name:
     return get_default_resolver().canonical_name(name)
 
 
-def try_ddr(lifetime: float = 5.0) -> None:
+def try_ddr(lifetime: float = 5.0) -> None:  # pragma: no cover
     """Try to update the default resolver's nameservers using Discovery of Designated
     Resolvers (DDR).  If successful, the resolver will subsequently use
     DNS-over-HTTPS or DNS-over-TLS for future queries.
@@ -1959,7 +1959,7 @@ def _getfqdn(name=None):
         (name, _, _) = _gethostbyaddr(name)
         # Python's version checks aliases too, but our gethostbyname
         # ignores them, so we do so here as well.
-    except Exception:
+    except Exception:  # pragma: no cover
         pass
     return name