From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Wed, 8 Jan 2014 16:36:19 +0000 (-0500)
Subject: - add more critical behavioral change for [ticket:2804]
X-Git-Tag: rel_0_9_2~83
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=58fe2fb81af7fa0b52a3d1760db3035a99c54b07;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- add more critical behavioral change for [ticket:2804]
---

diff --git a/doc/build/changelog/migration_09.rst b/doc/build/changelog/migration_09.rst
index 29e0042bc7..c68dfdda3f 100644
--- a/doc/build/changelog/migration_09.rst
+++ b/doc/build/changelog/migration_09.rst
@@ -9,7 +9,7 @@ What's New in SQLAlchemy 0.9?
     and SQLAlchemy version 0.9, which is expected for release
     in late 2013.
 
-    Document last updated: January 5, 2014
+    Document last updated: January 8, 2014
 
 Introduction
 ============
@@ -402,6 +402,54 @@ This is a small change demonstrated as follows::
 Behavioral Changes - Core
 =========================
 
+``None`` can no longer be used as a "partial AND" constructor
+--------------------------------------------------------------
+
+``None`` can no longer be used as the "backstop" to form an AND condition piecemeal.
+This pattern was not a documented pattern even though some SQLAlchemy internals
+made use of it::
+
+    condition = None
+
+    for cond in conditions:
+        condition = condition & cond
+
+    if condition is not None:
+        stmt = stmt.where(condition)
+
+The above sequence, when ``condition`` is non-empty, will on 0.9 produce
+``SELECT .. WHERE <condition> AND NULL``.  The ``None`` is no longer implicitly
+ignored.
+
+The correct code for both 0.8 and 0.9 should read::
+
+    from sqlalchemy.sql import and_
+
+    if conditions:
+        stmt = stmt.where(and_(*conditions))
+
+Another variant that works on all backends on 0.9, but on 0.8 only works on
+backends that support boolean constants::
+
+    from sqlalchemy.sql import true
+
+    condition = true()
+
+    for cond in conditions:
+        condition = cond & condition
+
+    if condition is not None:
+        stmt = stmt.where(condition)
+
+On 0.8, this will produce a SELECT statement that always has ``AND true``
+in the WHERE clause, which is not accepted by backends that don't support
+boolean constants (MySQL, MSSQL).  On 0.9, the ``true`` constant will be dropped
+within an ``and_()`` conjunction.
+
+.. seealso::
+
+    :ref:`migration_2804`
+
 .. _migration_2873:
 
 The "password" portion of a ``create_engine()`` no longer considers the ``+`` sign as an encoded space