From: Petr Menšík <pemensik@redhat.com>
Date: Wed, 19 Jan 2022 13:47:13 +0000 (+0100)
Subject: Initialize printed buffer
X-Git-Tag: v9.19.1~30^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=59132bd3ec8a9f648a1e1cf59f5f3b2d59f17927;p=thirdparty%2Fbind9.git

Initialize printed buffer

- var_decl: Declaring variable "tbuf" without initializer
- assign: Assigning: "target.base" = "tbuf", which points to
  uninitialized data
- assign: Assigning: "r.base" = "target.base", which points to
  uninitialized data

I expect it would correctly initialize length always. Add simple
initialization to silent coverity.
---

diff --git a/bin/dig/host.c b/bin/dig/host.c
index 1a42a87386a..436e9d77413 100644
--- a/bin/dig/host.c
+++ b/bin/dig/host.c
@@ -211,15 +211,9 @@ printsection(dns_message_t *msg, dns_section_t sectionid,
 	isc_result_t result, loopresult;
 	isc_region_t r;
 	dns_name_t empty_name;
-	char tbuf[4096];
+	char tbuf[4096] = { 0 };
 	bool first;
-	bool no_rdata;
-
-	if (sectionid == DNS_SECTION_QUESTION) {
-		no_rdata = true;
-	} else {
-		no_rdata = false;
-	}
+	bool no_rdata = (sectionid == DNS_SECTION_QUESTION);
 
 	if (headers) {
 		printf(";; %s SECTION:\n", section_name);