From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 30 Aug 2022 11:46:03 +0000 (+0200)
Subject: lib530: simplify realloc failure exit path
X-Git-Tag: curl-7_85_0~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=592290ed75654d89f96bfc0aa6e589fbea34a058;p=thirdparty%2Fcurl.git

lib530: simplify realloc failure exit path

To make code analyzers happier

Closes #9392
---

diff --git a/tests/libtest/lib530.c b/tests/libtest/lib530.c
index 1ab990780e..22577275cd 100644
--- a/tests/libtest/lib530.c
+++ b/tests/libtest/lib530.c
@@ -92,14 +92,12 @@ static int addFd(struct Sockets *sockets, curl_socket_t fd, const char *what)
     sockets->max_count = 20;
   }
   else if(sockets->count + 1 > sockets->max_count) {
-    curl_socket_t *oldptr = sockets->sockets;
-    sockets->sockets = realloc(oldptr, sizeof(curl_socket_t) *
-                               (sockets->max_count + 20));
-    if(!sockets->sockets) {
+    curl_socket_t *ptr = realloc(sockets->sockets, sizeof(curl_socket_t) *
+                                 (sockets->max_count + 20));
+    if(!ptr)
       /* cleanup in test_cleanup */
-      sockets->sockets = oldptr;
       return 1;
-    }
+    sockets->sockets = ptr;
     sockets->max_count += 20;
   }
   /*
@@ -361,7 +359,6 @@ test_cleanup:
   /* free local memory */
   free(sockets.read.sockets);
   free(sockets.write.sockets);
-
   return res;
 }