From: Michal 'vorner' Vaner <michal.vaner@nic.cz>
Date: Tue, 19 Feb 2013 10:04:07 +0000 (+0100)
Subject: [2676] (minor) Explain a FIXME comment
X-Git-Tag: bind10-1.1.0beta1-release~83^2~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=59651a74809b06c0228d2b39202335fffaee048e;p=thirdparty%2Fkea.git

[2676] (minor) Explain a FIXME comment
---

diff --git a/src/bin/zonemgr/zonemgr.py.in b/src/bin/zonemgr/zonemgr.py.in
index 94e93f86cf..59900c4655 100755
--- a/src/bin/zonemgr/zonemgr.py.in
+++ b/src/bin/zonemgr/zonemgr.py.in
@@ -279,7 +279,10 @@ class ZonemgrRefresh:
         """Send command between modules."""
         try:
             self._mccs.rpc_call(command_name, module_name, params=params)
-        except socket.error: # FIXME: WTF?
+        except socket.error:
+            # FIXME: WTF? Where does socket.error come from? And how do we ever
+            # dare ignore such serious error? It can only be broken link to
+            # msgq, we need to terminate then.
             logger.error(ZONEMGR_SEND_FAIL, module_name)
         except (isc.cc.session.SessionTimeout, isc.config.RPCError):
             pass        # for now we just ignore the failure