From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Sun, 20 Jul 2008 18:36:44 +0000 (+0000)
Subject: - more accurate changelog message
X-Git-Tag: rel_0_5beta3~25
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=59b25a513a0c0fa934a66c80963221bec4c90e8b;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- more accurate changelog message
- generalized the descriptor detection to any object with a __get__ attribute
---

diff --git a/CHANGES b/CHANGES
index f6bd11f66c..b10e0a1cd8 100644
--- a/CHANGES
+++ b/CHANGES
@@ -15,12 +15,17 @@ CHANGES
     - A critical fix to dynamic relations allows the 
       "modified" history to be properly cleared after
       a flush().
-    
-    - An inheriting class can now override an attribute
-      inherited from the base class with a plain descriptor, 
-      or exclude an inherited attribute via the 
+
+    - user-defined @properties on a class are detected
+      and left in place during mapper initialization.
+      This means that a table-bound column of the same
+      name will not be mapped at all if a @property is
+      in the way (and the column is not remapped to 
+      a different name), nor will an instrumented attribute
+      from an inherited class be applied.  The same
+      rules apply for names excluded using the 
       include_properties/exclude_properties collections.
-      
+
     - Added a new SessionExtension hook called after_attach().
       This is called at the point of attachment for objects
       via add(), add_all(), delete(), and merge().
diff --git a/lib/sqlalchemy/orm/mapper.py b/lib/sqlalchemy/orm/mapper.py
index f313a09ee7..7332e3104a 100644
--- a/lib/sqlalchemy/orm/mapper.py
+++ b/lib/sqlalchemy/orm/mapper.py
@@ -647,9 +647,8 @@ class Mapper(object):
         
         """
         # check for an existing descriptor
-        if isinstance(
-            getattr(self.class_, name, None),
-            property):
+        if getattr(self.class_, name, None) \
+            and hasattr(getattr(self.class_, name), '__get__'):
             return True
         
         if (self.include_properties is not None and
diff --git a/test/orm/inheritance/basic.py b/test/orm/inheritance/basic.py
index 4600ee063d..da03d2f995 100644
--- a/test/orm/inheritance/basic.py
+++ b/test/orm/inheritance/basic.py
@@ -848,6 +848,29 @@ class OverrideColKeyTest(ORMTest):
         sess.add(s1)
         sess.flush()
         assert sess.query(Sub).one().data == "im the data"
+
+    def test_custom_descriptor(self):
+        """test that descriptors prevent inheritance from propigating properties to subclasses."""
+
+        class MyDesc(object):
+            def __get__(self, instance, owner):
+                if instance is None:
+                    return self
+                return "im the data"
+            
+        class Base(object):
+            pass
+        class Sub(Base):
+            data = MyDesc()
+
+        mapper(Base, base)
+        mapper(Sub, subtable, inherits=Base)
+
+        s1 = Sub()
+        sess = create_session()
+        sess.add(s1)
+        sess.flush()
+        assert sess.query(Sub).one().data == "im the data"
         
 
 if __name__ == "__main__":