From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Thu, 20 Oct 2022 11:14:45 +0000 (+0200)
Subject: modern C: use O_APPEND instead of open+lseek
X-Git-Tag: RELEASE_1_4_0a1~94
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=59be7fffbe0ec2f36b219b943ccfa17c6af59fc2;p=thirdparty%2Fmlmmj.git

modern C: use O_APPEND instead of open+lseek
---

diff --git a/src/mlmmj-sub.c b/src/mlmmj-sub.c
index 5c8c1aef..7d46f5b0 100644
--- a/src/mlmmj-sub.c
+++ b/src/mlmmj-sub.c
@@ -613,7 +613,7 @@ static void subscribe_type(char *listdir, char *listaddr, char *listdelim,
 		exit(EXIT_FAILURE);
 	}
 
-	subfilefd = open(subfilename, O_RDWR|O_CREAT,
+	subfilefd = open(subfilename, O_RDWR|O_CREAT|O_APPEND,
 				S_IRUSR|S_IWUSR|groupwritable);
 	if(subfilefd == -1) {
 		log_error(LOG_ARGS, "Could not open '%s'", subfilename);
@@ -630,7 +630,6 @@ static void subscribe_type(char *listdir, char *listaddr, char *listdelim,
 		exit(EXIT_FAILURE);
 	}
 
-	lseek(subfilefd, 0L, SEEK_END);
 	len = strlen(address);
 	address[len] = '\n';
 	writen(subfilefd, address, len + 1);
diff --git a/src/send_list.c b/src/send_list.c
index 7c7b5dae..73648119 100644
--- a/src/send_list.c
+++ b/src/send_list.c
@@ -196,15 +196,11 @@ void send_list(const char *listdir, const char *emailaddr,
 	/* DEPRECATED */
 	/* Add lists manually if they weren't encountered in the list text */
 	if (!normalsls->used && !digestsls->used && !nomailsls->used) {
-		fd = open(queuefilename, O_WRONLY);
+		fd = open(queuefilename, O_WRONLY|O_APPEND);
 		if(fd < 0) {
 			log_error(LOG_ARGS, "Could not open sub list mail");
 			exit(EXIT_FAILURE);
 		}
-		if(lseek(fd, 0, SEEK_END) < 0) {
-			log_error(LOG_ARGS, "Could not seek to end of file");
-			exit(EXIT_FAILURE);
-		}
 		print_subs(fd, normalsls);
 		writen(fd, "\n-- \n", 5);
 		print_subs(fd, nomailsls);