From: Eric Lippert Date: Mon, 22 Oct 2018 15:52:46 +0000 (-0700) Subject: Fix issue 34551 - remove redundant store (#9009) X-Git-Tag: v3.8.0a1~705 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5a95ba29da7e55fe6a8777b6ea4c68f60cf0e407;p=thirdparty%2FPython%2Fcpython.git Fix issue 34551 - remove redundant store (#9009) The assignment of i/2 to nk is redundant because on this code path, nk is already the size of the dictionary, and i is already twice the size of the dictionary. I've replaced the store with an assertion that i/2 is nk. --- diff --git a/Objects/call.c b/Objects/call.c index 1937a8b2278e..bda05738755a 100644 --- a/Objects/call.c +++ b/Objects/call.c @@ -352,7 +352,7 @@ _PyFunction_FastCallDict(PyObject *func, PyObject *const *args, Py_ssize_t nargs Py_INCREF(k[i+1]); i += 2; } - nk = i / 2; + assert(i / 2 == nk); } else { kwtuple = NULL;