From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 5 Feb 2009 07:50:56 +0000 (+1300)
Subject: Bug 2588: coredump in rDNS lookup
X-Git-Tag: SQUID_3_2_0_1~1214
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5ad05949a20a05643a4bd5ae6e592cbbd0d7f871;p=thirdparty%2Fsquid.git

Bug 2588: coredump in rDNS lookup

Handle rDNS of invalid IP gracefully.
---

diff --git a/src/fqdncache.cc b/src/fqdncache.cc
index 371274e177..1e55d4fb52 100644
--- a/src/fqdncache.cc
+++ b/src/fqdncache.cc
@@ -639,7 +639,10 @@ fqdncache_gethostbyaddr(IpAddress &addr, int flags)
     char name[MAX_IPSTRLEN];
     fqdncache_entry *f = NULL;
 
-    assert(!addr.IsAnyAddr() && !addr.IsNoAddr());
+    if (addr.IsAnyAddr() || addr.IsNoAddr()) {
+        return NULL;
+    }
+
     addr.NtoA(name,MAX_IPSTRLEN);
     FqdncacheStats.requests++;
     f = fqdncache_get(name);