From: Björn Jacke <bj@sernet.de>
Date: Sun, 25 Aug 2019 21:09:19 +0000 (+0200)
Subject: wscript: avoid inefficient string concatenations
X-Git-Tag: talloc-2.3.1~715
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5ad629dcb957e45637f3a71309fa51abd87b267d;p=thirdparty%2Fsamba.git

wscript: avoid inefficient string concatenations

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
---

diff --git a/wscript b/wscript
index 579d35f2719..3e04df04080 100644
--- a/wscript
+++ b/wscript
@@ -419,10 +419,9 @@ def wafdocs(ctx):
     os.system('pwd')
     list = recursive_dirlist('../buildtools/wafsamba', '.', pattern='*.py')
 
-    cmd='PYTHONPATH=bin/python pydoctor --project-name=wafsamba --project-url=http://www.samba.org --make-html --docformat=restructuredtext'
     print(list)
-    for f in list:
-        cmd += ' --add-module %s' % f
+    cmd='PYTHONPATH=bin/python pydoctor --project-name=wafsamba --project-url=http://www.samba.org --make-html --docformat=restructuredtext' +\
+        "".join(' --add-module %s' % f for f in list)
     print("Running: %s" % cmd)
     status = os.system(cmd)
     if os.WEXITSTATUS(status):