From: Volker Lendecke <vl@samba.org>
Date: Thu, 23 May 2024 14:12:53 +0000 (+0200)
Subject: lib: Fix an error path memleak
X-Git-Tag: tdb-1.4.11~482
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5ae1605fc22acf672f46ba08f6b2ef4f675e92b8;p=thirdparty%2Fsamba.git

lib: Fix an error path memleak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/util/asn1.c b/lib/util/asn1.c
index 52b91b51d00..4ce85e9b0d9 100644
--- a/lib/util/asn1.c
+++ b/lib/util/asn1.c
@@ -308,8 +308,11 @@ bool ber_write_OID_String(TALLOC_CTX *mem_ctx, DATA_BLOB *blob, const char *OID)
 		v = smb_strtoul(p, &newp, 10, &error, SMB_STR_STANDARD);
 		if (newp[0] == '.' || error != 0) {
 			p = newp + 1;
-			/* check for empty last component */
-			if (!*p) return false;
+			if (!*p) {
+				/* empty last component */
+				data_blob_free(blob);
+				return false;
+			}
 		} else if (newp[0] == '\0') {
 			p = newp;
 		} else {