From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 31 Jan 2023 13:21:49 +0000 (+0100)
Subject: pid1,sysusers: drop unused SYNTHETIC_ERRNO
X-Git-Tag: v253-rc2~10^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5afdb4629aeb2cd20f3f7ba7e4b10f5d92be6a76;p=thirdparty%2Fsystemd.git

pid1,sysusers: drop unused SYNTHETIC_ERRNO

The only function of SYNTHETIC_ERRNO is to set the return value.
If we're ignoring the return value, it shouldn't be used.
---

diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c
index 0ed2d1b31d4..ce15758901a 100644
--- a/src/core/load-fragment.c
+++ b/src/core/load-fragment.c
@@ -4606,7 +4606,7 @@ int config_parse_exec_directories(
                 if (r == -ENOMEM)
                         return log_oom();
                 if (r <= 0) {
-                        log_syntax(unit, LOG_WARNING, filename, line, r ?: SYNTHETIC_ERRNO(EINVAL),
+                        log_syntax(unit, LOG_WARNING, filename, line, r,
                                    "Invalid syntax in %s=, ignoring: %s", lvalue, tuple);
                         return 0;
                 }
diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c
index 4a695fcfabd..4c31f963019 100644
--- a/src/sysusers/sysusers.c
+++ b/src/sysusers/sysusers.c
@@ -1811,7 +1811,7 @@ static int parse_line(const char *fname, unsigned line, const char *buffer) {
                 if (r < 0)
                         return r;
                 if (r == 0)
-                        log_syntax(NULL, LOG_WARNING, fname, line, SYNTHETIC_ERRNO(EUCLEAN),
+                        log_syntax(NULL, LOG_WARNING, fname, line, 0,
                                    "Conflict with earlier configuration for %s '%s', ignoring line.",
                                    item_type_to_string(i->type), i->name);