From: Greg Price <gnprice@gmail.com>
Date: Wed, 21 Aug 2019 03:50:51 +0000 (-0700)
Subject: bpo-35518: Skip test that relies on a deceased network service. (GH-15349)
X-Git-Tag: v3.9.0a1~841
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5b95a1507e349da5adae6d2ab57deac3bdd12f15;p=thirdparty%2FPython%2Fcpython.git

bpo-35518: Skip test that relies on a deceased network service. (GH-15349)

If this service had thoroughly vanished, we could just ignore the
test until someone gets around to either recreating such a service
or redesigning the test to somehow work locally.  The
`support.transient_internet` mechanism catches the failure to
resolve the domain name, and skips the test.

But in fact the domain snakebite.net does still exist, as do its
nameservers -- and they can be quite slow to reply.  As a result
this test can easily take 20-30s before it gets auto-skipped.

So, skip the test explicitly up front.
---

diff --git a/Lib/test/test_timeout.py b/Lib/test/test_timeout.py
index b54fc826ae0a..b07c07cbfc4d 100644
--- a/Lib/test/test_timeout.py
+++ b/Lib/test/test_timeout.py
@@ -150,6 +150,7 @@ class TCPTimeoutTestCase(TimeoutTestCase):
     def tearDown(self):
         self.sock.close()
 
+    @unittest.skipIf(True, 'need to replace these hosts; see bpo-35518')
     def testConnectTimeout(self):
         # Testing connect timeout is tricky: we need to have IP connectivity
         # to a host that silently drops our packets.  We can't simulate this