From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Thu, 8 Jul 2021 08:19:55 +0000 (+0100)
Subject: [Minor] Skip useless abs as we use squares
X-Git-Tag: 3.0~194
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5bee2f7fbd9274a3b23211218bbd26d098ecdddd;p=thirdparty%2Frspamd.git

[Minor] Skip useless abs as we use squares

Suggested by: trave11er
---

diff --git a/src/libserver/html/html_block.hxx b/src/libserver/html/html_block.hxx
index 122d35aa32..76b41c14cf 100644
--- a/src/libserver/html/html_block.hxx
+++ b/src/libserver/html/html_block.hxx
@@ -185,11 +185,12 @@ struct html_block {
 		}
 
 		auto is_similar_colors = [](const rspamd::css::css_color &fg, const rspamd::css::css_color &bg) -> bool {
-			auto diff_r = std::abs(fg.r - bg.r);
-			auto diff_g = std::abs(fg.g - bg.g);
-			auto diff_b = std::abs(fg.b - bg.b);
+			auto diff_r = ((float)fg.r - bg.r);
+			auto diff_g = ((float)fg.g - bg.g);
+			auto diff_b = ((float)fg.b - bg.b);
 			auto ravg = (fg.r + bg.r) / 2.0;
 
+			/* Square diffs */
 			diff_r *= diff_r;
 			diff_g *= diff_g;
 			diff_b *= diff_b;