From: Victor Julien <victor@inliniac.net>
Date: Wed, 15 Aug 2012 15:13:33 +0000 (+0200)
Subject: stream: fix unittest broken by new flags handling.
X-Git-Tag: suricata-1.3.1~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5cc8a092574a3365863d9abf3b25a4b508bd5548;p=thirdparty%2Fsuricata.git

stream: fix unittest broken by new flags handling.
---

diff --git a/src/stream-tcp.c b/src/stream-tcp.c
index 6686649886..4ea3d4823b 100644
--- a/src/stream-tcp.c
+++ b/src/stream-tcp.c
@@ -5066,18 +5066,28 @@ static int StreamTcpTest06 (void) {
     tcph.th_flags = TH_FIN;
     p->tcph = &tcph;
 
-    if (StreamTcpPacket(&tv, p, &stt, &pq) == -1)
+    /* StreamTcpPacket returns -1 on unsolicited FIN */
+    if (StreamTcpPacket(&tv, p, &stt, &pq) != -1) {
+        printf("StreamTcpPacket failed: ");
         goto end;
+    }
 
-    if (((TcpSession *)(p->flow->protoctx)) != NULL)
+    if (((TcpSession *)(p->flow->protoctx)) != NULL) {
+        printf("we have a ssn while we shouldn't: ");
         goto end;
+    }
 
     p->tcph->th_flags = TH_RST;
-    if (StreamTcpPacket(&tv, p, &stt, &pq) == -1)
+    /* StreamTcpPacket returns -1 on unsolicited RST */
+    if (StreamTcpPacket(&tv, p, &stt, &pq) != -1) {
+        printf("StreamTcpPacket failed (2): ");
         goto end;
+    }
 
-    if (((TcpSession *)(p->flow->protoctx)) != NULL)
+    if (((TcpSession *)(p->flow->protoctx)) != NULL) {
+        printf("we have a ssn while we shouldn't (2): ");
         goto end;
+    }
 
     ret = 1;
 end: