From: Amos Jeffries <squid3@treenet.co.nz>
Date: Fri, 25 Mar 2011 07:24:26 +0000 (+1300)
Subject: basic_ldap_auth: error message for missing credentials
X-Git-Tag: take06~27^2~69
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5cde6e7f53eb77db6d868ff88bbb6f9e5d622323;p=thirdparty%2Fsquid.git

basic_ldap_auth: error message for missing credentials
---

diff --git a/helpers/basic_auth/LDAP/basic_ldap_auth.cc b/helpers/basic_auth/LDAP/basic_ldap_auth.cc
index 68e8cc5423..63b6c2fb4b 100644
--- a/helpers/basic_auth/LDAP/basic_ldap_auth.cc
+++ b/helpers/basic_auth/LDAP/basic_ldap_auth.cc
@@ -571,14 +571,18 @@ main(int argc, char **argv)
         user = strtok(buf, " \r\n");
         passwd = strtok(NULL, "\r\n");
 
-        if (!user || !passwd || !passwd[0]) {
-            printf("ERR\n");
+        if (!user) {
+            printf("ERR Missing username\n");
+            continue;
+        }
+        if (!passwd || !passwd[0]) {
+            printf("ERR Missing password '%s'\n", user);
             continue;
         }
         rfc1738_unescape(user);
         rfc1738_unescape(passwd);
         if (!validUsername(user)) {
-            printf("ERR No such user\n");
+            printf("ERR No such user '%s':'%s'\n",user, passwd);
             continue;
         }
         tryagain = (ld != NULL);