From: Razvan Becheriu <razvan.becheriu@qualitance.com>
Date: Thu, 7 Jul 2016 08:33:12 +0000 (+0300)
Subject: fixed scripts and compilation errors for different compilers
X-Git-Tag: kea5574_base~10^2~1^2~38
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5ce7af33edcb462c7685bfe2dfeef082bb1d1340;p=thirdparty%2Fkea.git

fixed scripts and compilation errors for different compilers
---

diff --git a/src/bin/admin/kea-admin.in b/src/bin/admin/kea-admin.in
index 60bf797b8d..deff62229d 100644
--- a/src/bin/admin/kea-admin.in
+++ b/src/bin/admin/kea-admin.in
@@ -203,8 +203,8 @@ pgsql_init() {
 cql_init() {
     printf "Checking if there is a database initialized already... Please ignore errors.\n"
 
-    result=`cql_execute "USE $db_name; DESCRIBE tables;"`
-    if [ "$result"="<empty>" ]; then
+    result=`cql_execute "DESCRIBE tables;"`
+    if [ `echo "$result" | grep "<empty>" | wc -w` -gt 0 ]; then
         printf "Creating and initializing tables using script %s...\n" $scripts_dir/cql/dhcpdb_create.cql
         cql_execute_script $scripts_dir/cql/dhcpdb_create.cql
     else
diff --git a/src/lib/dhcpsrv/cql_exchange.h b/src/lib/dhcpsrv/cql_exchange.h
index ab78b417f0..db55fa6471 100644
--- a/src/lib/dhcpsrv/cql_exchange.h
+++ b/src/lib/dhcpsrv/cql_exchange.h
@@ -113,12 +113,11 @@ public:
     /// all variables are initialized/set in the methods before they are used.
     CqlVersionExchange() {
         // Set the column names
-        const size_t MAX_COLUMNS = 2U;
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("version",
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_IN_OUT, EXCHANGE_DATA_TYPE_INT32)));
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("minor",
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_IN_OUT, EXCHANGE_DATA_TYPE_INT32)));
-        BOOST_ASSERT(parameters_.size() == MAX_COLUMNS);
+        BOOST_ASSERT(parameters_.size() == 2U);
     }
 };
 
diff --git a/src/lib/dhcpsrv/cql_lease_mgr.cc b/src/lib/dhcpsrv/cql_lease_mgr.cc
index f1641ab26e..8317464343 100644
--- a/src/lib/dhcpsrv/cql_lease_mgr.cc
+++ b/src/lib/dhcpsrv/cql_lease_mgr.cc
@@ -407,7 +407,6 @@ public:
     /// all variables are initialized/set in the methods before they are used.
     CqlLease4Exchange() : addr4_(0) {
         // Set the column names
-        const size_t MAX_COLUMNS = 12U;
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("address",
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_IN_OUT, EXCHANGE_DATA_TYPE_INT32)));
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("hwaddr",
@@ -432,7 +431,7 @@ public:
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_IN_OUT, EXCHANGE_DATA_TYPE_INT32)));
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("[applied]",
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_IN_OUT, EXCHANGE_DATA_TYPE_BOOL)));
-        BOOST_ASSERT(parameters_.size() == MAX_COLUMNS);
+        BOOST_ASSERT(parameters_.size() == 12U);
     }
 
     /// @brief Create CQL_BIND objects for Lease4 Pointer
@@ -640,7 +639,6 @@ public:
     CqlLease6Exchange() : pref_lifetime_(0), lease_type_(0), iaid_(0),
                           prefixlen_(0), hwtype_(0), hwaddr_source_(0) {
         // Set the column names
-        const size_t MAX_COLUMNS = 18U;
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("address",
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_IN_OUT, EXCHANGE_DATA_TYPE_STRING)));
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("duid",
@@ -677,7 +675,7 @@ public:
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_IN_OUT, EXCHANGE_DATA_TYPE_INT32)));
         parameters_.push_back(ExchangeColumnInfoPtr(new ExchangeColumnInfo("[applied]",
             parameters_.size(), EXCHANGE_DATA_TYPE_IO_OUT, EXCHANGE_DATA_TYPE_BOOL)));
-        BOOST_ASSERT(parameters_.size() == MAX_COLUMNS);
+        BOOST_ASSERT(parameters_.size() == 18U);
     }
 
     /// @brief Create CQL_BIND objects for Lease6 Pointer