From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 2 Aug 2023 02:27:01 +0000 (+1200)
Subject: libcli/security: Remove unused function sid_compare_domain()
X-Git-Tag: tevent-0.16.0~1165
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5cf61ed2e3b217b0d1313cc7cb94a44b11ef0863;p=thirdparty%2Fsamba.git

libcli/security: Remove unused function sid_compare_domain()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/security/dom_sid.h b/libcli/security/dom_sid.h
index d99713cb914..c5500a13dd7 100644
--- a/libcli/security/dom_sid.h
+++ b/libcli/security/dom_sid.h
@@ -123,7 +123,6 @@ bool sid_peek_rid(const struct dom_sid *sid, uint32_t *rid);
 bool sid_peek_check_rid(const struct dom_sid *exp_dom_sid, const struct dom_sid *sid, uint32_t *rid);
 void sid_copy(struct dom_sid *dst, const struct dom_sid *src);
 ssize_t sid_parse(const uint8_t *inbuf, size_t len, struct dom_sid *sid);
-int sid_compare_domain(const struct dom_sid *sid1, const struct dom_sid *sid2);
 NTSTATUS add_sid_to_array(TALLOC_CTX *mem_ctx, const struct dom_sid *sid,
 			  struct dom_sid **sids, uint32_t *num);
 NTSTATUS add_sid_to_array_unique(TALLOC_CTX *mem_ctx, const struct dom_sid *sid,
diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c
index 668ce720b6a..b878935bea6 100644
--- a/libcli/security/util_sid.c
+++ b/libcli/security/util_sid.c
@@ -330,24 +330,6 @@ ssize_t sid_parse(const uint8_t *inbuf, size_t len, struct dom_sid *sid)
 	return ndr_size_dom_sid(sid, 0);
 }
 
-/*****************************************************************
- See if 2 SIDs are in the same domain
- this just compares the leading sub-auths
-*****************************************************************/
-
-int sid_compare_domain(const struct dom_sid *sid1, const struct dom_sid *sid2)
-{
-	int n, i;
-
-	n = MIN(sid1->num_auths, sid2->num_auths);
-
-	for (i = n-1; i >= 0; --i)
-		if (sid1->sub_auths[i] != sid2->sub_auths[i])
-			return sid1->sub_auths[i] - sid2->sub_auths[i];
-
-	return dom_sid_compare_auth(sid1, sid2);
-}
-
 /********************************************************************
  Add SID to an array of SIDs
 ********************************************************************/