From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sun, 22 Sep 2024 18:30:32 +0000 (+0900)
Subject: network/address: warn but ignore Broadcast= setting for an IPv6 address
X-Git-Tag: v257-rc1~249^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5d15c7b19cae6d3332d4e213c380e0fcc1317a2c;p=thirdparty%2Fsystemd.git

network/address: warn but ignore Broadcast= setting for an IPv6 address

Previously, the below was refused and the IPv6 address would not assigned.
===
[Address]
Address=2001:db8:0:f101::15/64
Broadcast=192.168.0.255
===
However, in the following case, networkd warned about the broadcast
address would be ignored, and the IPv6 address would be configured.
===
[Address]
Broadcast=192.168.0.255
Address=2001:db8:0:f101::15/64
===
---

diff --git a/src/network/networkd-address.c b/src/network/networkd-address.c
index 2464f4bf15c..e2fec8e268d 100644
--- a/src/network/networkd-address.c
+++ b/src/network/networkd-address.c
@@ -2048,12 +2048,6 @@ static int config_parse_broadcast(
                 return 1;
         }
 
-        if (address->family == AF_INET6) {
-                log_syntax(unit, LOG_WARNING, filename, line, 0,
-                           "Broadcast is not valid for IPv6 addresses, ignoring assignment: %s", rvalue);
-                return 0;
-        }
-
         r = in_addr_from_string(AF_INET, rvalue, &u);
         if (r < 0)
                 return log_syntax_parse_error(unit, filename, line, r, lvalue, rvalue);